viirya commented on code in PR #1738:
URL: https://github.com/apache/arrow-rs/pull/1738#discussion_r880824560
##########
arrow/src/compute/kernels/cast.rs:
##########
@@ -280,6 +280,8 @@ pub fn can_cast_types(from_type: &DataType, to_type:
&DataType) -> bool {
///
/// Behavior:
/// * Boolean to Utf8: `true` => '1', `false` => `0`
+/// * Utf8 to boolean: `true`, `yes`, `on`, `1` => `true`, `false`, `no`,
`off`, `0` => `false`,
Review Comment:
I just looked at C++ Arrow:
https://github.com/apache/arrow/blob/b8431fba68e2540b3e57def0bd0ad718652c4b98/cpp/src/arrow/util/value_parsing.h#L92.
Seems it only converts "0", "1", "true", "false". Should we follow it and
remove "on", "off", "yes", "no"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
