korowa commented on code in PR #2591:
URL: https://github.com/apache/arrow-datafusion/pull/2591#discussion_r882067908
##########
datafusion/core/src/optimizer/filter_push_down.rs:
##########
@@ -1143,6 +1145,7 @@ mod tests {
&right,
JoinType::Inner,
(vec![Column::from_name("a")], vec![Column::from_name("a")]),
+ None,
Review Comment:
pushdown logic for ON condition is not supported in this PR, I've added
tests (currently ignored) for this, and added an issue
https://github.com/apache/arrow-datafusion/issues/2619
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
