korowa commented on code in PR #2591:
URL: https://github.com/apache/arrow-datafusion/pull/2591#discussion_r882107323


##########
datafusion/core/src/physical_plan/planner.rs:
##########
@@ -773,6 +775,65 @@ impl DefaultPhysicalPlanner {
                         })
                         .collect::<Result<join_utils::JoinOn>>()?;
 
+                    let join_filter = match filter {

Review Comment:
   I thought about it, but decided that it would be kind of mess to add a bunch 
of logical plan related imports and entities to hash_join.
   + I guess, if join internal storage is going to change, that will lead us to 
changing ColumnIndices somehow, and planner still is going to be affected (but 
I may be wrong).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to