pitrou commented on code in PR #13315:
URL: https://github.com/apache/arrow/pull/13315#discussion_r891131156
##########
cpp/src/arrow/flight/server.cc:
##########
@@ -157,8 +157,11 @@ struct FlightServerBase::Impl {
void DoHandleSignal(int signum) {
got_signal_ = signum;
int saved_errno = errno;
- // Ignore errors - pipe is nonblocking
- PIPE_WRITE(self_pipe_wfd_, "0", 1);
+ if (PIPE_WRITE(self_pipe_wfd_, "0", 1) < 0) {
+ // Can't do much here, though, pipe is nonblocking so hopefully this
doesn't happen
+ ARROW_LOG(WARNING) << "FlightServerBase: failed to handle signal " <<
signum
+ << " errno: " << errno;
+ }
Review Comment:
Just FTR, I opened https://issues.apache.org/jira/browse/ARROW-16769 to make
this easier and nicer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
