ming535 commented on code in PR #2694:
URL: https://github.com/apache/arrow-datafusion/pull/2694#discussion_r892271376
##########
datafusion/core/src/physical_plan/planner.rs:
##########
@@ -906,15 +905,14 @@ impl DefaultPhysicalPlanner {
} else {
// Apply a LocalLimitExec to each partition. The
optimizer will also insert
// a CoalescePartitionsExec between the
GlobalLimitExec and LocalLimitExec
- Arc::new(LocalLimitExec::new(input, limit))
+ if let Some(fetch) = fetch {
+ Arc::new(LocalLimitExec::new(input, *fetch))
Review Comment:
fixed, and added a new test case with multi-partitioned table.
##########
datafusion/core/src/physical_optimizer/repartition.rs:
##########
@@ -449,13 +450,13 @@ mod tests {
"AggregateExec: mode=Final, gby=[], aggr=[]",
"AggregateExec: mode=Partial, gby=[], aggr=[]",
"RepartitionExec: partitioning=RoundRobinBatch(10)",
- "GlobalLimitExec: limit=100",
- "LocalLimitExec: limit=100",
+ "GlobalLimitExec: skip=None, fetch=100",
+ "LocalLimitExec: fetch=100",
"FilterExec: c1@0",
// repartition should happen prior to the filter to maximize
parallelism
"RepartitionExec: partitioning=RoundRobinBatch(10)",
- "GlobalLimitExec: limit=100",
- "LocalLimitExec: limit=100",
+ "GlobalLimitExec: skip=None, fetch=100",
+ "LocalLimitExec: fetch=100",
// Expect no repartition to happen for local limit
"ParquetExec: limit=None, partitions=[x], projection=[c1]",
];
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
