romainfrancois commented on a change in pull request #8150:
URL: https://github.com/apache/arrow/pull/8150#discussion_r486193205
##########
File path: r/R/table.R
##########
@@ -185,6 +185,36 @@ Table <- R6Class("Table", inherit = ArrowObject,
)
)
+bad_attributes <- function(x) {
+ UseMethod("bad_attributes")
+}
+
+bad_attributes.default <- function(x) character()
+bad_attributes.data.frame <- function(x) c("class", "row.names", "names")
Review comment:
We might actually want to keep the class for data frames, so that we
would faithfully roundtrip data frames, instead of enforcing a tibble:
``` r
library(arrow, warn.conflicts = FALSE)
as.data.frame(record_batch(df = data.frame(x = 1)))$df
#> # A tibble: 1 x 1
#> x
#> <dbl>
#> 1 1
```
<sup>Created on 2020-09-10 by the [reprex
package](https://reprex.tidyverse.org) (v0.3.0.9001)</sup>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
