sunchao commented on code in PR #1960:
URL: https://github.com/apache/arrow-rs/pull/1960#discussion_r909253062
##########
arrow/src/ffi.rs:
##########
@@ -450,7 +450,17 @@ impl FFI_ArrowArray {
let buffers = iter::once(data.null_buffer().cloned())
.chain(data.buffers().iter().map(|b| Some(b.clone())))
.collect::<Vec<_>>();
- let n_buffers = buffers.len() as i64;
Review Comment:
I see. Do we need to keep `n_buffers` in sync with `buffers.len`? in the
case of null array, `buffers.len` is 1 with a null pointer, while `n_buffers`
becomes 0 after this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
