sunchao commented on code in PR #1960:
URL: https://github.com/apache/arrow-rs/pull/1960#discussion_r909263824
##########
arrow/src/ffi.rs:
##########
@@ -450,7 +450,17 @@ impl FFI_ArrowArray {
let buffers = iter::once(data.null_buffer().cloned())
.chain(data.buffers().iter().map(|b| Some(b.clone())))
.collect::<Vec<_>>();
- let n_buffers = buffers.len() as i64;
Review Comment:
Yea. According to the spec of `buffers`:
> Mandatory. A C array of pointers to the start of each physical buffer
backing this array. Each void* pointer is the physical start of a contiguous
buffer. There must be
[ArrowArray.n_buffers](https://arrow.apache.org/docs/format/CDataInterface.html#c.ArrowArray.n_buffers)
pointers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
