pschou commented on code in PR #13463:
URL: https://github.com/apache/arrow/pull/13463#discussion_r910309463
##########
go/parquet/cmd/parquet_reader/Makefile:
##########
@@ -0,0 +1,6 @@
+PROG_NAME := "parquet_reader"
+VERSION = 0.1.$(shell date -u +%Y%m%d.%H%M)
Review Comment:
> This version should probably reflect the Arrow/Parquet version rather than
being `0.1.<date>`, can we use something like: `TAG=$(git name-rev --tags
--name-only $(git rev-parse HEAD)) && TAG=${TAG%^0} && TAG=${TAG#apache-arrow-}
&& echo $TAG` which will get the current tag and remove the `apache-arrow-`
prefix to get the version on it's own? then combine it with the date.
Do you have a template Makefile that would work better?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
