nevi-me commented on a change in pull request #8174:
URL: https://github.com/apache/arrow/pull/8174#discussion_r487448427
##########
File path: rust/arrow/src/ipc/mod.rs
##########
@@ -36,3 +36,4 @@ pub use self::gen::SparseTensor::*;
pub use self::gen::Tensor::*;
static ARROW_MAGIC: [u8; 6] = [b'A', b'R', b'R', b'O', b'W', b'1'];
Review comment:
is `const` better than `static` here? IIRC I used static for
`ARROW_MAGIC` when const either wasn't a thing yet, or I was unfamiliar with it.
##########
File path: rust/arrow/src/ipc/mod.rs
##########
@@ -36,3 +36,4 @@ pub use self::gen::SparseTensor::*;
pub use self::gen::Tensor::*;
static ARROW_MAGIC: [u8; 6] = [b'A', b'R', b'R', b'O', b'W', b'1'];
Review comment:
is `const` better than `static` here? IIRC I used static for
`ARROW_MAGIC` when const either wasn't a thing yet, or I was unfamiliar with it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
