andygrove commented on PR #2812: URL: https://github.com/apache/arrow-datafusion/pull/2812#issuecomment-1171352809
> > Since DataFusion can be used in various contexts inside other systems, I would like to be able to disable the "take configs from the environment" behavior to allow people to turn off potential "back doors" -- for example, I do not want to allow users of IOx, my project, to override internal datafusion settings via the environment. > > So perhaps we could add a ConfigOptions::from_env() function rather than parsing environment from new() > > Good point. @avantgardnerio Is the intention of this feature to mainly be used for `datafusion-cli` and similar programs where the user doesn't have direct access to the session? > > If so I think your suggestion would work fine - `datafusion-cli` could use the env version and everyone else could use the normal version. I also like having two different methods of constructing configs - one that allows env var overrides and one that does not. I can imagine that Ballista executors would want to use the env var version to allow for easier configuration in k8s through config maps for example. Also makes sense for the CLI, IMO. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
