liukun4515 commented on code in PR #1977:
URL: https://github.com/apache/arrow-rs/pull/1977#discussion_r911932308
##########
parquet/src/file/reader.rs:
##########
@@ -86,6 +95,14 @@ pub trait RowGroupReader: Send + Sync {
/// Get page reader for the `i`th column chunk.
fn get_column_page_reader(&self, i: usize) -> Result<Box<dyn PageReader>>;
+ /// Get page reader for the `i`th column chunk with offset index(in one
row group).
+ /// `row_group_pages_offset_index` construct from pageIndex and input
rowRanges, here we skip needless page.
+ fn get_column_page_reader_with_offset_index(
+ &self,
+ column_index: usize,
+ row_group_pages_offset_index: &[FilterOffsetIndex],
Review Comment:
```suggestion
page_offset_index : &FilterOffsetIndex,
```
a reference of struct is enough.
I can't figure out a good name for parameter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
