liukun4515 commented on code in PR #1977:
URL: https://github.com/apache/arrow-rs/pull/1977#discussion_r911938903
##########
parquet/src/file/serialized_reader.rs:
##########
@@ -248,21 +286,23 @@ impl<R: 'static + ChunkReader> SerializedFileReader<R> {
}
if options.enable_page_index {
- //Todo for now test data `data_index_bloom_encoding_stats.parquet`
only have one rowgroup
- //support multi after create multi-RG test data.
- let cols = metadata.row_group(0);
- let columns_indexes =
- index_reader::read_columns_indexes(&chunk_reader,
cols.columns())?;
- let pages_locations =
- index_reader::read_pages_locations(&chunk_reader,
cols.columns())?;
+ let mut columns_indexes = vec![];
Review Comment:
Column index should be loaded by lazy.
Loading the full column index at the beginning is very heavy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
