tustvold commented on code in PR #1995:
URL: https://github.com/apache/arrow-rs/pull/1995#discussion_r912419382
##########
parquet/src/column/reader.rs:
##########
@@ -163,26 +163,18 @@ where
}
}
- /// Reads a batch of values of at most `batch_size`.
+ /// Reads a batch of values of at most `batch_size`, returning a tuple
containing the
Review Comment:
This is the breaking change, we could make this non-breaking by always
returning 0 if max_def_level == 0 && max_rep_level == 0, but I personally think
this is a little bit confusing. This make the behaviour consistent, instead of
potentially varying based on the column definition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
