liukun4515 commented on code in PR #2809:
URL: https://github.com/apache/arrow-datafusion/pull/2809#discussion_r912479940
##########
datafusion/physical-expr/src/expressions/in_list.rs:
##########
@@ -532,66 +521,131 @@ impl PhysicalExpr for InListExpr {
match value_data_type {
DataType::Boolean => {
let array =
array.as_any().downcast_ref::<BooleanArray>().unwrap();
- set_contains_with_negated!(array, set, self.negated)
+ Ok(set_contains_for_primitive!(
Review Comment:
`set_contains_utf` and `make_set_contains_decimal` are just apply to a
specified data type case which are not compatible with other primitive case.
`set_contains_for_primitive` will apply to many similar case and same logic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
