HaoYang670 commented on code in PR #2042:
URL: https://github.com/apache/arrow-rs/pull/2042#discussion_r917615553
##########
arrow/src/ffi.rs:
##########
@@ -284,6 +284,10 @@ impl FFI_ArrowSchema {
pub fn dictionary(&self) -> Option<&Self> {
unsafe { self.dictionary.as_ref() }
}
+
+ pub fn map_keys_sorted(&self) -> bool {
+ (self.flags / 4) & 1 == 1
Review Comment:
nit (not tests)
```rust
self.flags & 0b100 !=0
```
I am not sure if there is any function in the std library to check a bit is
set or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
