rtpsw commented on code in PR #13500:
URL: https://github.com/apache/arrow/pull/13500#discussion_r918328965
##########
cpp/src/arrow/engine/substrait/serde.cc:
##########
@@ -204,6 +203,48 @@ Result<compute::ExecPlan> DeserializePlan(
return MakeSingleDeclarationPlan(declarations);
}
+Result<std::vector<UdfDeclaration>> DeserializePlanUdfs(
+ const Buffer& buf, const ExtensionIdRegistry* registry) {
+ ARROW_ASSIGN_OR_RAISE(auto plan, ParseFromBuffer<substrait::Plan>(buf));
+
+ ARROW_ASSIGN_OR_RAISE(auto ext_set, GetExtensionSetFromPlan(plan, registry,
true));
+
+ std::vector<UdfDeclaration> decls;
+ /*
Review Comment:
This code compiles (and passes locally implemented tests I have) with code i
proposed to Substrait that is pending agreement as noted in this [explanation
post](https://github.com/apache/arrow/pull/13500#issuecomment-1173041442). For
now, it goes to show the logic that's going to be implemented here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
