rtpsw commented on code in PR #13500:
URL: https://github.com/apache/arrow/pull/13500#discussion_r918335922
##########
cpp/src/arrow/engine/substrait/util.h:
##########
@@ -39,6 +39,9 @@ ARROW_ENGINE_EXPORT
Result<std::shared_ptr<RecordBatchReader>> ExecuteSerialized
ARROW_ENGINE_EXPORT Result<std::shared_ptr<Buffer>> SerializeJsonPlan(
const std::string& substrait_json);
+ARROW_ENGINE_EXPORT Result<std::vector<compute::Declaration>> DeserializePlans(
+ const Buffer& buf, const ExtensionIdRegistry* registry);
Review Comment:
The main purpose of `util.h` is to expose functions to PyArrow.
Nevertheless, I'll go over these function to see what can be simplified,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
