viirya commented on code in PR #2040:
URL: https://github.com/apache/arrow-rs/pull/2040#discussion_r919257679
##########
arrow/src/ipc/writer.rs:
##########
@@ -894,12 +1031,66 @@ fn write_array_data(
Some(buffer) => buffer.clone(),
};
- offset = write_buffer(&null_buffer, buffers, arrow_data, offset);
+ offset = write_buffer(null_buffer.as_slice(), buffers, arrow_data,
offset);
Review Comment:
`null_buffer.as_slice()` already takes the slice from the offset from null
buffer. I think it is you meant materializing the buffers (null buffer and
value buffers)? The difference now is this also truncate the length from value
buffers but not for null buffer (we can do it by using `bit_slice` then).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
