tustvold commented on code in PR #2040:
URL: https://github.com/apache/arrow-rs/pull/2040#discussion_r919340795
##########
arrow/src/ipc/writer.rs:
##########
@@ -894,12 +1031,66 @@ fn write_array_data(
Some(buffer) => buffer.clone(),
};
- offset = write_buffer(&null_buffer, buffers, arrow_data, offset);
+ offset = write_buffer(null_buffer.as_slice(), buffers, arrow_data,
offset);
Review Comment:
There are two offsets, the offset within the null buffer which `as_slice`
applies, and the offset from the ArrayData which `as_slice` cannot possibly
apply as it has no idea what it is (and it is an offset in bits and not bytes).
I would like to see a test of a nullable sliced array, it is possible I'm
mistaken, but I am pretty certain this will break
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
