liukun4515 commented on code in PR #2076:
URL: https://github.com/apache/arrow-rs/pull/2076#discussion_r922092728


##########
parquet/src/arrow/array_reader/byte_array.rs:
##########
@@ -653,6 +787,57 @@ mod tests {
         }
     }
 
+    #[test]
+    fn test_byte_array_decoder_skip() {
+        let (pages, encoded_dictionary) =

Review Comment:
   It's better to add more test cases:
   1. all values are null for corner case
   2. skip value with null data.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to