tustvold commented on code in PR #2116:
URL: https://github.com/apache/arrow-rs/pull/2116#discussion_r927063681
##########
parquet/src/column/reader.rs:
##########
@@ -195,7 +195,6 @@ where
///
/// `values` will be contiguously populated with the non-null values. Note
that if the column
/// is not required, this may be less than either `batch_size` or the
number of levels read
- #[inline]
Review Comment:
When you leave `inline` certain benchmarks get slower when compiled from the
parquet crate, although there is no difference when compiled from the workspace
level... It is incredibly strange...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
