lidavidm commented on code in PR #13492:
URL: https://github.com/apache/arrow/pull/13492#discussion_r930165069
##########
format/FlightSql.proto:
##########
@@ -1450,8 +1484,48 @@ message ActionClosePreparedStatementRequest {
bytes prepared_statement_handle = 1;
}
+/*
+ * Request message for the "BeginTransaction" action.
+ * Begins a transaction or creates a savepoint within a transaction.
+ */
+message ActionBeginTransactionRequest {
+ // Create a savepoint within the identified transaction. Only supported if
+ // FLIGHT_SQL_TRANSACTION is FLIGHT_SQL_TRANSACTION_SUPPORT_SAVEPOINT.
+ bytes transaction_id = 1;
Review Comment:
Hopefully it's clearer now that it's split. The ID is always server
assigned. To begin a savepoint, you must provide the ID of the transaction it
falls under.
##########
format/FlightSql.proto:
##########
@@ -1475,6 +1577,35 @@ message CommandStatementQuery {
// The SQL syntax.
string query = 1;
+ // Include the query as part of this transaction (if unset, the query is
auto-committed).
+ bytes transaction_id = 2;
Review Comment:
These `transaction_id` fields should be explicitly marked `optional`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
