lidavidm commented on code in PR #13492:
URL: https://github.com/apache/arrow/pull/13492#discussion_r929291081
##########
format/FlightSql.proto:
##########
@@ -1450,8 +1500,55 @@ message ActionClosePreparedStatementRequest {
bytes prepared_statement_handle = 1;
}
+/*
+ * Request message for the "BeginTransaction" action.
+ * Begins a transaction or creates a savepoint within a transaction.
+ */
+message ActionBeginTransactionRequest {
+ // The transaction to which a savepoint belongs, if applicable.
+ //
+ // To begin a transaction, leave this field empty.
Review Comment:
Split into separate commands (though the response messasge and
EndTransaction are still shared)
##########
format/FlightSql.proto:
##########
@@ -89,6 +90,31 @@ enum SqlInfo {
*/
FLIGHT_SQL_SERVER_READ_ONLY = 3;
+ /*
+ * Retrieves a boolean value indicating whether the Flight SQL Server
supports executing Substrait plans.
+ */
+ FLIGHT_SQL_SUBSTRAIT = 4;
+
+ /*
+ * Retrieves an int32 indicating whether the Flight SQL Server supports
explicit transaction RPCs.
+ *
+ * The possible values are listed in `FlightSqlTransactionSupport`.
+ */
+ FLIGHT_SQL_TRANSACTION = 5;
+
+ /*
+ * Retrieves an int32 indicating the timeout for prepared statement handles.
Review Comment:
I made it milliseconds, unless we prefer floating point seconds?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
