liukun4515 commented on code in PR #2968: URL: https://github.com/apache/arrow-datafusion/pull/2968#discussion_r931731720
########## datafusion/row/src/writer.rs: ########## @@ -349,7 +349,7 @@ pub(crate) fn write_field_utf8( let from = from.as_any().downcast_ref::<StringArray>().unwrap(); let s = from.value(row_idx); let new_width = to.current_width() + s.as_bytes().len(); Review Comment: I figure out the corner case to panic for your fix. You can add the test with string data type, but the each value of array is empty, just like that ``` arrow::array::StringArray::from(vec!["","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","","",""]); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org