andygrove commented on a change in pull request #8222:
URL: https://github.com/apache/arrow/pull/8222#discussion_r492074780
##########
File path: rust/datafusion/src/physical_plan/hash_aggregate.rs
##########
@@ -48,9 +48,12 @@ use fnv::FnvHashMap;
/// Hash aggregate modes
#[derive(Debug, Copy, Clone)]
pub enum AggregateMode {
+ /// Aggregate mode without any partial/intermediate aggregation
+ NoPartial,
Review comment:
Spark uses the term `Complete`. Our existing names `Partial` and `Final`
were based on Spark's naming.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
