viirya commented on code in PR #2275:
URL: https://github.com/apache/arrow-rs/pull/2275#discussion_r935087546
##########
arrow/src/util/decimal.rs:
##########
@@ -245,6 +245,49 @@ macro_rules! def_decimal {
};
}
+// compare two signed integer which are encoded with little endian.
+// left bytes and right bytes must have the same length.
+fn singed_cmp_le_bytes(left: &[u8], right: &[u8]) -> Ordering {
+ assert_eq!(
+ left.len(),
+ right.len(),
+ "Can't compare bytes array with different len: {}, {}",
+ left.len(),
+ right.len()
+ );
+ assert_ne!(left.len(), 0, "Can't compare bytes array of length 0");
+ let len = left.len();
+ let left_negative = left[len - 1] >= 0x80_u8;
+ let right_negative = right[len - 1] >= 0x80_u8;
+ if left_negative != right_negative {
+ return match left_negative {
+ true => {
+ // left is negative value
+ // right is positive value
+ Ordering::Less
+ }
+ false => {
+ //
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
