liukun4515 commented on code in PR #2360:
URL: https://github.com/apache/arrow-rs/pull/2360#discussion_r940113059
##########
arrow/src/array/array_decimal.rs:
##########
@@ -336,6 +336,31 @@ impl BasicDecimalArray<Decimal128, Decimal128Array> for
Decimal128Array {
}
Ok(())
}
+
+ fn validate_decimal_with_bytes(&self, precision: usize) -> Result<()> {
Review Comment:
yes, i think the overhead is from the `xxDecimal::new()` and convert to
`i128`.
Using this pr method, we can improve the performance from reducing above
overhead.
In current `iter` or `index ` decimal array, the result of value is
Decimal128 and Decimal256.
In many case, we don't need the struct of decimal, and just need the
little-endian bytes.
Can we add more method to `index` or `iter` decimal array, and the result
type of value is `&[u8]`?
Do you mean this?
@tustvold
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
