liukun4515 commented on code in PR #2357:
URL: https://github.com/apache/arrow-rs/pull/2357#discussion_r940141195
##########
parquet/src/arrow/array_reader/primitive_array.rs:
##########
@@ -208,7 +210,7 @@ where
))
}
}
- .with_precision_and_scale(p, s)?;
+ .with_precision_and_scale(p, s, false)?;
Review Comment:
> Hmm, how do we know that we don't need to do validation here? The decimal
type can be specified, what if user specify a smaller precision?
Why user can specify a new data type and not the type from parquet schema?
If you can specify the type there may be other error when the specified type is
not compatible with the data in the parquet. Although the current interface is
this with specified data type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
