3dbrows commented on PR #13633: URL: https://github.com/apache/arrow/pull/13633#issuecomment-1208059470
Added a test which is perhaps strange. It doesn't check whether we have assigned a particular kind of AWS strategy, as I'm not sure how we'd do that. Instead, it tests whether the strategy actually assigned matches the behaviour of the expected strategy. In other words, check it does retry after 1 attempt; does not after 6 attempts; and check the retry delay is in the expected range as per AWS docs. This could be vastly simplified if someone knows how to mock out a static Cython method such that we can simply "assert that `CS3RetryStrategy.GetAwsStandardRetryStrategy()` was called with X as a parameter". Alternatively, maybe it's _preferable_ that we're testing the behaviour here rather than what code is executed. I'm not sure how to handle passing the strategy in the `__reduce__` method. A bit stuck there. Very much open to suggestions on both points (or really: opinionated instructions on what to do). I think I have reached the limit of what I can do myself here without guidance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
