HaoYang670 commented on code in PR #2360:
URL: https://github.com/apache/arrow-rs/pull/2360#discussion_r941303072
##########
arrow/src/datatypes/datatype.rs:
##########
@@ -263,6 +265,706 @@ impl fmt::Display for DataType {
}
}
+// Max decimal128 value of little-endian format for each precision.
+pub(crate) const MAX_DECIMAL_BYTES_FOR_EACH_PRECISION: [[u8; 16]; 38] = [
+ 9_i128.to_le_bytes(),
+ 99_i128.to_le_bytes(),
+ 999_i128.to_le_bytes(),
+ 9999_i128.to_le_bytes(),
+ 99999_i128.to_le_bytes(),
+ 999999_i128.to_le_bytes(),
+ 9999999_i128.to_le_bytes(),
+ 99999999_i128.to_le_bytes(),
+ 999999999_i128.to_le_bytes(),
+ 9999999999_i128.to_le_bytes(),
+ 99999999999_i128.to_le_bytes(),
+ 999999999999_i128.to_le_bytes(),
+ 9999999999999_i128.to_le_bytes(),
+ 99999999999999_i128.to_le_bytes(),
+ 999999999999999_i128.to_le_bytes(),
+ 9999999999999999_i128.to_le_bytes(),
+ 99999999999999999_i128.to_le_bytes(),
+ 999999999999999999_i128.to_le_bytes(),
+ 9999999999999999999_i128.to_le_bytes(),
+ 99999999999999999999_i128.to_le_bytes(),
+ 999999999999999999999_i128.to_le_bytes(),
+ 9999999999999999999999_i128.to_le_bytes(),
+ 99999999999999999999999_i128.to_le_bytes(),
+ 999999999999999999999999_i128.to_le_bytes(),
+ 9999999999999999999999999_i128.to_le_bytes(),
+ 99999999999999999999999999_i128.to_le_bytes(),
+ 999999999999999999999999999_i128.to_le_bytes(),
+ 9999999999999999999999999999_i128.to_le_bytes(),
+ 99999999999999999999999999999_i128.to_le_bytes(),
+ 999999999999999999999999999999_i128.to_le_bytes(),
+ 9999999999999999999999999999999_i128.to_le_bytes(),
+ 99999999999999999999999999999999_i128.to_le_bytes(),
+ 999999999999999999999999999999999_i128.to_le_bytes(),
+ 9999999999999999999999999999999999_i128.to_le_bytes(),
+ 99999999999999999999999999999999999_i128.to_le_bytes(),
+ 999999999999999999999999999999999999_i128.to_le_bytes(),
+ 9999999999999999999999999999999999999_i128.to_le_bytes(),
+ 99999999999999999999999999999999999999_i128.to_le_bytes(),
+];
+
+// Min decimal128 value of little-endian format for each precision.
+pub(crate) const MIN_DECIMAL_BYTES_FOR_EACH_PRECISION: [[u8; 16]; 38] = [
+ (-9_i128).to_le_bytes(),
+ (-99_i128).to_le_bytes(),
+ (-999_i128).to_le_bytes(),
+ (-9999_i128).to_le_bytes(),
+ (-99999_i128).to_le_bytes(),
+ (-999999_i128).to_le_bytes(),
+ (-9999999_i128).to_le_bytes(),
+ (-99999999_i128).to_le_bytes(),
+ (-999999999_i128).to_le_bytes(),
+ (-9999999999_i128).to_le_bytes(),
+ (-99999999999_i128).to_le_bytes(),
+ (-999999999999_i128).to_le_bytes(),
+ (-9999999999999_i128).to_le_bytes(),
+ (-99999999999999_i128).to_le_bytes(),
+ (-999999999999999_i128).to_le_bytes(),
+ (-9999999999999999_i128).to_le_bytes(),
+ (-99999999999999999_i128).to_le_bytes(),
+ (-999999999999999999_i128).to_le_bytes(),
+ (-9999999999999999999_i128).to_le_bytes(),
+ (-99999999999999999999_i128).to_le_bytes(),
+ (-999999999999999999999_i128).to_le_bytes(),
+ (-9999999999999999999999_i128).to_le_bytes(),
+ (-99999999999999999999999_i128).to_le_bytes(),
+ (-999999999999999999999999_i128).to_le_bytes(),
+ (-9999999999999999999999999_i128).to_le_bytes(),
+ (-99999999999999999999999999_i128).to_le_bytes(),
+ (-999999999999999999999999999_i128).to_le_bytes(),
+ (-9999999999999999999999999999_i128).to_le_bytes(),
+ (-99999999999999999999999999999_i128).to_le_bytes(),
+ (-999999999999999999999999999999_i128).to_le_bytes(),
+ (-9999999999999999999999999999999_i128).to_le_bytes(),
+ (-99999999999999999999999999999999_i128).to_le_bytes(),
+ (-999999999999999999999999999999999_i128).to_le_bytes(),
+ (-9999999999999999999999999999999999_i128).to_le_bytes(),
+ (-99999999999999999999999999999999999_i128).to_le_bytes(),
+ (-999999999999999999999999999999999999_i128).to_le_bytes(),
+ (-9999999999999999999999999999999999999_i128).to_le_bytes(),
+ (-99999999999999999999999999999999999999_i128).to_le_bytes(),
+];
+
+// MAX decimal256 value of little-endian format for each precision.
+pub(crate) const MAX_DECIMAL_BYTES_FOR_LARGER_EACH_PRECISION: [[u8; 32]; 76] =
[
Review Comment:
Could you please add more docs, as there are lots of magical values ?
Besides, is there any way to check these numbers are right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
