liukun4515 commented on code in PR #2376:
URL: https://github.com/apache/arrow-rs/pull/2376#discussion_r941921274
##########
arrow/src/array/data.rs:
##########
@@ -401,11 +401,17 @@ impl ArrayData {
#[inline]
pub(crate) fn with_data_type(mut self, new_data_type: DataType) -> Self {
assert!(
- matches!(self.data_type, DataType::Decimal128(_, _)),
+ matches!(
Review Comment:
Can we change from the data type of decimal128array to decimal256array?
We can't change the type of decimal128array to decimal256(p,s), I think
decimal128 and decimal256 are diff data type, for the data of decimal128array
and decimal256array use the diff layout and diff data length for each value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
