liukun4515 commented on code in PR #2376:
URL: https://github.com/apache/arrow-rs/pull/2376#discussion_r941922825
##########
arrow/src/array/data.rs:
##########
@@ -401,11 +401,17 @@ impl ArrayData {
#[inline]
pub(crate) fn with_data_type(mut self, new_data_type: DataType) -> Self {
assert!(
- matches!(self.data_type, DataType::Decimal128(_, _)),
+ matches!(
Review Comment:
Just can change decimal128(p1,s1) to decimal128(p2,s2) and decimal256(p1,s1)
to decimal256(p2,s2), and can't change decimal128(p1,s1) to decimal256(p2,s2)
or decimal256(p1,s1) to decimal128(p2,s2)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
