Ted-Jiang commented on PR #2393:
URL: https://github.com/apache/arrow-rs/pull/2393#issuecomment-1211661827
> I'm not confident that as written this will actually improve performance,
perhaps we could get a benchmark? I've also added some suggestions of how to
make it faster
Thanks for your useful guidance!
After #2407
i write a bench got
```
arrow_array_reader/Int32Array/binary packed skip, mandatory, no NULLs
time: [81.636 us 82.772 us 83.944 us]
change: [+98.920% +102.00% +105.13%] (p = 0.00 <
0.05)
Performance has regressed.
arrow_array_reader/Int32Array/binary packed skip, optional, no NULLs
time: [91.932 us 92.774 us 93.612 us]
change: [+76.901% +80.245% +83.995%] (p = 0.00 <
0.05)
Performance has regressed.
```
😠there is a regressed !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
