ManManson commented on PR #13796: URL: https://github.com/apache/arrow/pull/13796#issuecomment-1212848116
Force-pushed the branch to address review comments from @pitrou and @westonpace . The diff can be found here: https://github.com/apache/arrow/compare/136ae80540f851219c8d9a920470d4863a428d30..ac2954d39b5de052b3c05563d290f00c23b51b34 Changelog: * Change new option fields types from `uint32_t` to `int32_t` * Renamed `batch_size` to `file_info_batch_size` * Incorporated some code simplifications proposed by @pitrou * Added a benchmark for the new impl of `LocalFileSystem::GetFileInfoGenerator` * Discovered a bug with prematurely closed producer while running the benchmark, somehow it escaped manual testing until now... Introduced `AutoClosingProducer` to solve the problem -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
