ManManson commented on PR #13796: URL: https://github.com/apache/arrow/pull/13796#issuecomment-1217125505
Force-pushed the branch to address review comments from @pitrou The diff can be found there: https://github.com/apache/arrow/compare/affcca7fa308c897ff5a358d1668486abed6c5fa..09142855f750ea046fb081c17d23b5fa675f7e9f Changelog: * Removed `AutoClosingProducer` in favor of a more simplistic and correct `std::shared_ptr<DiscoveryState>` approach * Sub-generators are scheduled on the same IO executor so that we don't do redundant transitions between CPU and IO threads * Pass `io_executor` from the `LocalFileSystem` down to the discovery algorithm, so that we don't have to use the `io::get_default_io_context()` * Fixes to comments * Minor code fixes (e.g. swapping current chunk contens in `DiscoveryImplIterator`) proposed by @pitrou * Remove unused `boost` dependencies for localfs benchmark * Remove dependency on parquet in the localfs benchmark * Reduce the number of argument ranges to the benchmark -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
