alamb commented on code in PR #3161:
URL: https://github.com/apache/arrow-datafusion/pull/3161#discussion_r946088490
##########
datafusion/core/src/physical_plan/hash_utils.rs:
##########
@@ -43,11 +43,11 @@ fn hash_null(random_state: &RandomState, hashes_buffer: &'_
mut [u64], mul_col:
if mul_col {
hashes_buffer.iter_mut().for_each(|hash| {
// stable hash for null value
- *hash = combine_hashes(i128::get_hash(&1, random_state), *hash);
+ *hash = combine_hashes(random_state.hash_one(&1), *hash);
Review Comment:
Largely the same change @Dandandan applied in
https://github.com/apache/arrow-rs/pull/2410
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
