rtpsw commented on code in PR #13880:
URL: https://github.com/apache/arrow/pull/13880#discussion_r946972128
##########
cpp/src/arrow/compute/exec/asof_join_node.cc:
##########
@@ -137,18 +167,84 @@ struct MemoStore {
}
};
+// a specialized higher-performance variation of Hashing64 logic
Review Comment:
The doc string is a bit misleading. The logic here is faster than the
[`Hashing64` logic in
`hash_join`](https://github.com/apache/arrow/blob/d880d7517a33f2ac8ff259cad711bc210fd570c5/cpp/src/arrow/compute/exec/hash_join_node.cc#L1164-L1178),
because the latter recreates/recomputes certain objects on every batch while
the former avoids that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
