Ted-Jiang commented on code in PR #2460:
URL: https://github.com/apache/arrow-rs/pull/2460#discussion_r948876802
##########
parquet/src/file/serialized_reader.rs:
##########
@@ -648,20 +659,60 @@ impl<R: ChunkReader> PageReader for
SerializedPageReader<R> {
}
fn peek_next_page(&mut self) -> Result<Option<PageMetadata>> {
- match &self.state {
- SerializedPageReaderState::Values {..} => Err(general_err!("Must
set page_offset_index when using peek_next_page in SerializedPageReader.")),
- SerializedPageReaderState::Pages { page_locations,
dictionary_page, total_rows } => {
+ match &mut self.state {
+ SerializedPageReaderState::Values {
+ offset,
+ remaining_bytes,
+ next_page_header,
+ } => {
+ loop {
+ if *remaining_bytes == 0 {
+ return Ok(None);
+ }
+ return if let Some(header) = next_page_header.take() {
Review Comment:
Yes, the only way set it none. Is after skip_next_page.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
