Ted-Jiang commented on code in PR #2460:
URL: https://github.com/apache/arrow-rs/pull/2460#discussion_r948886097
##########
parquet/src/file/serialized_reader.rs:
##########
@@ -480,13 +480,17 @@ pub(crate) fn decode_page(
Ok(result)
}
+#[allow(clippy::large_enum_variant)]
Review Comment:
you are right! tested in ut
```
#[test]
fn test() {
enum Test {
Large {
page: Option<PageHeader>,
}
}
let test1 = Test::Large { page: None };
println!("{}", std::mem::size_of_val(&test1));
()
}
```
got 320 😂 thanks for your info!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
