zhztheplayer commented on code in PR #13321:
URL: https://github.com/apache/arrow/pull/13321#discussion_r949746761
##########
java/vector/src/test/java/org/apache/arrow/vector/TestStructVector.java:
##########
@@ -171,13 +174,102 @@ public void testAddOrGetComplexChildVectors() {
vector.addOrGetStruct("struct");
vector.addOrGetMap("map", true);
- List<FieldVector> childrens = vector.getChildrenFromFields();
- assertEquals(5, childrens.size());
- assertEquals(MinorType.LIST, childrens.get(0).getMinorType());
- assertEquals(MinorType.FIXED_SIZE_LIST, childrens.get(1).getMinorType());
- assertEquals(MinorType.UNION, childrens.get(2).getMinorType());
- assertEquals(MinorType.STRUCT, childrens.get(3).getMinorType());
- assertEquals(MinorType.MAP, childrens.get(4).getMinorType());
+ List<FieldVector> children = vector.getChildrenFromFields();
+ assertEquals(5, children.size());
+ assertEquals(MinorType.LIST, children.get(0).getMinorType());
+ assertEquals(MinorType.FIXED_SIZE_LIST, children.get(1).getMinorType());
+ assertEquals(MinorType.UNION, children.get(2).getMinorType());
+ assertEquals(MinorType.STRUCT, children.get(3).getMinorType());
+ assertEquals(MinorType.MAP, children.get(4).getMinorType());
}
}
+
+ @Test
+ public void
testAddChildVectorsWithDuplicatedFieldNamesForConflictPolicyAppend() {
+ final FieldType type = new FieldType(true, Struct.INSTANCE, null, null);
+ try (StructVector vector = new StructVector("struct", allocator, type,
null,
+ AbstractStructVector.ConflictPolicy.CONFLICT_APPEND, true)) {
+ final List<Field> initFields = new ArrayList<>();
+
+ // Add a bit more fields to test against stability of the internal field
+ // ordering mechanism of StructVector
+ initFields.add(Field.nullable("varchar1", MinorType.VARCHAR.getType()));
+ initFields.add(Field.nullable("int1", MinorType.INT.getType()));
+ initFields.add(Field.nullable("varchar2", MinorType.VARCHAR.getType()));
+ initFields.add(Field.nullable("int2", MinorType.INT.getType()));
+ initFields.add(Field.nullable("varchar3", MinorType.VARCHAR.getType()));
+ initFields.add(Field.nullable("int3", MinorType.INT.getType()));
+
+ // To ensure duplicated field names don't mess up the original field
order
+ // in the struct vector
+ initFields.add(Field.nullable("varchar1", MinorType.VARCHAR.getType()));
+ initFields.add(Field.nullable("varchar2", MinorType.VARCHAR.getType()));
+ initFields.add(Field.nullable("varchar3", MinorType.VARCHAR.getType()));
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
