thinkharderdev commented on code in PR #2526:
URL: https://github.com/apache/arrow-rs/pull/2526#discussion_r950333821


##########
parquet/src/arrow/arrow_reader/selection.rs:
##########
@@ -162,7 +162,12 @@ impl RowSelection {
                     current_selector = selectors.next();
                 }
             } else {
-                break;
+                if !(selector.skip || current_page_included) {

Review Comment:
   Before we would break if we were on the last page. So if you skipped from 
inside the second to last page into the last page, then this would short 
circuit and the last page range wouldn't be selected. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to