thinkharderdev commented on code in PR #2526:
URL: https://github.com/apache/arrow-rs/pull/2526#discussion_r950364671
##########
parquet/src/arrow/async_reader.rs:
##########
@@ -493,13 +601,26 @@ impl<'a> InMemoryRowGroup<'a> {
let fetch_ranges = self
.column_chunks
.iter()
+ .zip(self.metadata.columns())
.enumerate()
.into_iter()
- .filter_map(|(idx, chunk)| {
+ .filter_map(|(idx, (chunk, chunk_meta))| {
(chunk.is_none() && projection.leaf_included(idx)).then(||
{
- let ranges =
selection.scan_ranges(&page_locations[idx]);
+ // If the first page does not start at the beginning
of the column,
+ // then we need to also fetch a dictionary page.
+ let mut ranges = vec![];
+ let (start, _len) = chunk_meta.byte_range();
+ match page_locations[idx].first() {
Review Comment:
Discovered this bug as well. We weren't fetching a dictionary page if it
existed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
