Dandandan commented on code in PR #2545:
URL: https://github.com/apache/arrow-rs/pull/2545#discussion_r950891139
##########
arrow/src/compute/kernels/comparison.rs:
##########
@@ -468,7 +468,7 @@ pub fn ilike_utf8_scalar<OffsetSize: OffsetSizeTrait>(
if !right.contains(is_like_pattern) {
// fast path, can use equals
for i in 0..left.len() {
- result.append(left.value(i) == right);
+ result.append(left.value(i).to_uppercase() ==
right.to_uppercase());
Review Comment:
Yes, and also outside the inner loop. The compiler often won't find out that
it's possible to do this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
