rtpsw commented on code in PR #13880:
URL: https://github.com/apache/arrow/pull/13880#discussion_r954271758
##########
cpp/src/arrow/compute/exec/asof_join_node.cc:
##########
@@ -459,17 +642,58 @@ class CompositeReferenceTable {
if (!_ptr2ref.count((uintptr_t)ref.get())) _ptr2ref[(uintptr_t)ref.get()]
= ref;
}
- template <class Builder, class PrimitiveType>
- Result<std::shared_ptr<Array>> MaterializePrimitiveColumn(MemoryPool*
memory_pool,
- size_t i_table,
- col_index_t i_col)
{
- Builder builder(memory_pool);
+ // this should really be a method on ArrayData
+ static bool IsNull(const std::shared_ptr<ArrayData>& source, row_index_t
row) {
Review Comment:
An `IsNull` method can be found in `ArraySpan`, but it doesn't make sense to
create these objects in `AsofJoinNode` just for using `IsNull`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
