rtpsw commented on code in PR #13880:
URL: https://github.com/apache/arrow/pull/13880#discussion_r954584973
##########
cpp/src/arrow/compute/exec/options.h:
##########
@@ -397,24 +397,51 @@ class ARROW_EXPORT HashJoinNodeOptions : public
ExecNodeOptions {
/// This node will output one row for each row in the left table.
class ARROW_EXPORT AsofJoinNodeOptions : public ExecNodeOptions {
public:
- AsofJoinNodeOptions(FieldRef on_key, FieldRef by_key, int64_t tolerance)
- : on_key(std::move(on_key)), by_key(std::move(by_key)),
tolerance(tolerance) {}
+ AsofJoinNodeOptions(FieldRef on_key, const FieldRef& by_key, int64_t
tolerance,
+ bool nullable_by_key = false)
+ : on_key(std::move(on_key)),
+ by_key(),
+ tolerance(tolerance),
+ nullable_by_key(nullable_by_key) {
+ this->by_key.push_back(std::move(by_key));
+ }
- /// \brief "on" key for the join. Each
+ AsofJoinNodeOptions(FieldRef on_key, std::vector<FieldRef> by_key, int64_t
tolerance,
+ bool nullable_by_key = false)
+ : on_key(std::move(on_key)),
+ by_key(by_key),
Review Comment:
According to [this
doc](https://en.cppreference.com/w/cpp/language/copy_elision), copy elision
should happen with a move as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
