viirya commented on code in PR #2643:
URL: https://github.com/apache/arrow-rs/pull/2643#discussion_r962253459
##########
arrow/src/compute/kernels/arithmetic.rs:
##########
@@ -1040,17 +1201,21 @@ pub fn divide_dyn(left: &dyn Array, right: &dyn Array)
-> Result<ArrayRef> {
}
/// Perform `left / right` operation on two arrays without checking for
division by zero.
-/// The result of dividing by zero follows normal floating point rules.
+/// For floating point types, the result of dividing by zero follows normal
floating point
+/// rules. For other numeric types, dividing by zero will panic,
Review Comment:
Hmm, `saturating_div` also panics when dividing by zero.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
