tustvold commented on code in PR #2643: URL: https://github.com/apache/arrow-rs/pull/2643#discussion_r962276598
########## arrow/src/compute/kernels/arithmetic.rs: ########## @@ -1013,18 +1171,21 @@ where /// Perform `left / right` operation on two arrays. If either left or right value is null /// then the result is also null. If any right hand value is zero then the result of this /// operation will be `Err(ArrowError::DivideByZero)`. -pub fn divide<T>( +/// +/// When `simd` feature is not enabled. This detects overflow and returns an `Err` for that. Review Comment: Interesting, that would imply rust division is always checked 🤔 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
