viirya commented on issue #2647: URL: https://github.com/apache/arrow-rs/issues/2647#issuecomment-1236394562
I am +1 for that the unchecked variant of these division kernels should do something else instead of panic. For the idea to fill a special value, just wondering if NULL is more suitable/meaningful for this case (Spark does this). Not strong option and also from performance perspective from the proposed optimization, it may not a good choice. For using 0 for dividing by zero slot, not sure if there is any other doing the same so this is my little concern. But I guess it is okay if we well define this behavior in the document. Btw, C++ `divide` kernel returns an error for integer division by zero like `divide_checked` does. For floating point, it doesn't specially handle it so it gets an infinity value. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
