drin commented on PR #13390: URL: https://github.com/apache/arrow/pull/13390#issuecomment-1240021655
I was trying to extend this PR, but rebasing made it complicated, so I opened a new one. The reviews I mainly see here are regarding getting the file extension from the Uri. In #14071 , I don't do this because substrait has fields that specify the file type. Code for this was added after this PR was opened, and can be see here (currently live in master): https://github.com/apache/arrow/blob/47314c3999d7b7a7f9167c6ed6793da756c411a1/cpp/src/arrow/engine/substrait/relation_internal.cc#L131-L141 It was because of this code that I rebased. I think this PR can be closed, and #14071 can replace it. There is a smaller change to `Uri` in that PR, but the update to `relation_internal.cc` is larger (but mostly organizational). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
